-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds update_package_properties and build_packages in pg-auto-failover-enterprise #713
Conversation
Should be blocked until #709 gots merged. After that one is complete, you can update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After addressing my comments, please compare Github Workflow definitions in all-pgautofailover
branch with the ones in here.
Co-authored-by: Hanefi Onaldi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove ubuntu/xenial from travis tests as well
.github/workflows/build-package.yml
Outdated
run: sudo apt-get update && sudo apt install libcurl4-openssl-dev libssl-dev | ||
|
||
- name: Install python requirements | ||
run: sudo apt-get update && python -m pip install -r tools/packaging_automation/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: sudo apt-get update && python -m pip install -r tools/packaging_automation/requirements.txt | |
run: python -m pip install -r tools/packaging_automation/requirements.txt |
no need to do this again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
pipelines