-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds bookworm into test images #339
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
de15052
Adds debian-bookworm and removes ubuntu-focal
gurkanindibay ae1b0f1
Updates package version
gurkanindibay 3b77810
Updates package version
gurkanindibay c6dc0f7
Updates package version
gurkanindibay 76b0ea5
Removes empty spaces from test images
gurkanindibay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,88 @@ | ||||
FROM debian:bookworm | ||||
ARG CITUS_VERSION | ||||
# FOrmat should be XY and should not include dots e.g for 10.2.1=>102 | ||||
ARG CITUS_MAJOR_VERSION | ||||
ARG PG_MAJOR | ||||
ARG FANCY=1 | ||||
ARG HLL_VERSION=2.18.citus-1 | ||||
ARG TOPN_VERSION=2.6.0.citus-1 | ||||
|
||||
ENV CITUS_VERSION ${CITUS_VERSION} | ||||
|
||||
ENV PG_MAJOR ${PG_MAJOR} | ||||
|
||||
ENV TZ=Europe/Istanbul | ||||
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone | ||||
|
||||
# install prequisities | ||||
RUN apt-get update \ | ||||
&& apt-get install -y lsb-release \ | ||||
apt-utils \ | ||||
vim \ | ||||
wget \ | ||||
curl \ | ||||
gnupg2 \ | ||||
software-properties-common \ | ||||
libcurl4-openssl-dev \ | ||||
libssl-dev | ||||
|
||||
|
||||
# install Citus | ||||
RUN apt-get update \ | ||||
&& apt-get install -y --no-install-recommends \ | ||||
ca-certificates \ | ||||
curl \ | ||||
&& curl -s https://install.citusdata.com/community/deb.sh | bash | ||||
RUN apt-get install -y postgresql-${PG_MAJOR}-citus-${CITUS_MAJOR_VERSION}=${CITUS_VERSION}.citus-${FANCY} \ | ||||
postgresql-$PG_MAJOR-hll=${HLL_VERSION} \ | ||||
postgresql-$PG_MAJOR-topn=${TOPN_VERSION} \ | ||||
&& rm -rf /var/lib/apt/lists/*12 | ||||
|
||||
|
||||
|
||||
ARG POSTGRES_HOME=/var/lib/postgresql/ | ||||
ENV PATH=${PATH}:/usr/lib/postgresql/${PG_MAJOR}/bin:${POSTGRES_HOME} | ||||
|
||||
WORKDIR ${POSTGRES_HOME} | ||||
|
||||
RUN mkdir citus && chown postgres citus | ||||
|
||||
USER postgres | ||||
RUN cd ~ && initdb -D citus && echo "shared_preload_libraries = 'citus'" >> citus/postgresql.conf | ||||
|
||||
USER root | ||||
# Install python 3.8 and its dependencies | ||||
RUN apt-get install -y build-essential \ | ||||
libcurl4-openssl-dev \ | ||||
libssl-dev \ | ||||
zlib1g-dev \ | ||||
curl \ | ||||
libffi-dev \ | ||||
gnupg2 && \ | ||||
curl https://www.python.org/ftp/python/3.8.12/Python-3.8.12.tgz --output Python-3.8.12.tgz &&\ | ||||
tar xvf Python-3.8.12.tgz &&\ | ||||
cd Python-3.8.*/ && \ | ||||
./configure --enable-optimizations && \ | ||||
make altinstall && \ | ||||
python3.8 -m pip install pip-tools | ||||
|
||||
COPY scripts/* ./ | ||||
|
||||
RUN pip-compile && python3.8 -m pip install -r requirements.txt | ||||
|
||||
USER postgres | ||||
|
||||
WORKDIR ${POSTGRES_HOME} | ||||
|
||||
CMD ["test_internal.sh"] | ||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Why so many empty lines? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there were empty spaces in other files and I formed this one from others. Removed empty spaces for all files now |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we not merge these
RUN
commands?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in sake of debugging purposes. If there is an error in a command, I have issues to find which statement causes this error.
Since this is not an image to publish, merging them will not give a benefit to us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is actually a benefit: the resulting docker image will be smaller. Every apt command that does not include
rm -rf /var/lib/apt/lists/*
at the end will result in bigger docker images, and having to download bigger docker images result in longer CI run times.