Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add strict types to boundaries and semantics #3

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

HideBa
Copy link

@HideBa HideBa commented Dec 22, 2024

Pull Request Overview

Summary of Changes

This Pull Request introduces strict typing to boundaries and semantics, leveraging Rust's strong type system. The current implementation utilizes the Value type, which can represent any data type, resulting in ambiguity for users of this library.

Benefits

  • Enhanced Type Safety: By implementing stronger typing, users will benefit from improved type safety, leading to fewer runtime errors and more predictable code behavior.
  • Simplified Integration with CityJSON: Users will no longer need to create their own implementation to interpret CityJSON's boundaries and semantics fields internal structure, as the library will now provide clearer and more robust type definitions.

Conclusion

These improvements will significantly enhance the usability and robustness of the library, making it easier for developers to work with CityJSON data in a type-safe manner.

@HideBa HideBa marked this pull request as draft December 22, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant