-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operating Authority Added Dropdown Menu View, Step Indicator, Print Notary #169
base: master
Are you sure you want to change the base?
Operating Authority Added Dropdown Menu View, Step Indicator, Print Notary #169
Conversation
- Added Big Button for Operating Authority (currently hidden using a page rule unless a Company user role) - Update comment on menu views for print between Chauffuer Permit and Operating Authority - Added print menu button for Operating Authority - Added Dropdown Menu View navigation (see gitbook) - Added CSS for Operating Authority Step Indicator and Print page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and i am following your changes and how they are being used in the app. I did not test this! Thanks for the TIL 😄
#view_640, #view_639 { | ||
display:none; | ||
} | ||
@media print { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL the print
media query 💡
// Dictonary of views needing dropdown menu in editable Operating Authority (OA) pages | ||
var viewNameOA = {687:"1 - Service Type",676:"2 - Business Information",689:"3 - Insurance", | ||
691:"4 - Authorized Person", 693:"5 - Vehicle Information", 695:"6 - Review and Submit"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to run this new code through a formatter. we typically use prettier, and there are plugins for most of the major IDEs.
for example, it'd be nice to have this object prettified:
var viewNameOA = {
687: "1 - Service Type",
676: "2 - Business Information",
689: "3 - Insurance",
691: "4 - Authorized Person",
693: "5 - Vehicle Information",
695: "6 - Review and Submit",
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a few things I noticed. They should be pretty easy fixes. Overall make sure your code looks & functions on mobile as well. Hope this helps!
@@ -46,14 +46,23 @@ | |||
} | |||
|
|||
/* This is for the bars */ | |||
.progressbar li{ | |||
.progressbar li{ /* Chauffeur Permit Form */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth moving these comments to new lines above as section headers so its easier to find each section
} | ||
|
||
/* hide knack menu buttons if on desktop */ | ||
@media (min-width: 799px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to double check this pixel width, Knack doesnt always display mobile correctly at 799px. Im using 767.9px & 768px in ROW Portal right now. you should see the hamburger menu in the top right on mobile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test this in mobile. 🫠 I borrowed some of the JS/CSS from ROW since it had the mobile codes.
FYI I found that the dropdown menu list is not good with touch screens due to lack of hover functionality (on my laptop touchscreen).
/****************************************/ | ||
|
||
/* hide custom menu if on mobile */ | ||
@media (max-width: 799px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to double check this pixel width, Knack doesnt always display mobile correctly at 799px. Im using 767.9px & 768px in ROW Portal right now.
Added Prettier and mobile styling
This is related to cityofaustin/atd-data-tech#20330 for Step Indicator and Menu view in Operating Authority.
The Dropdown Menu is documented here - https://atd-dts.gitbook.io/atd-knack-operations/knack-code/looks/dropdown-menu-buttons
Apologies that this is a lot since most of this was inherited from the earlier prototype github issue cityofaustin/atd-data-tech#19617
Changes in JavaScript
Added Big Button for Operating Authority (currently hidden using a page rule where user role contains `Customer`)
Update comment on menu views for print between Chauffeur Permit and Operating Authority
Added Print Menu Button for Operating Authority Notary
Added Dropdown Menu View navigation
tia
tooa
naming{view_number:"Form Name"}
line 215-217 for the 6 pages that need the specific menu view.for key in viewNameOA
in the dictionary for the six form pages starting from line 219-241<br>
tag before theappendTo
to fix visual spacing in line 239.Changes in CSS
#oa
line 57-65 to change the width of step indicator . Width is based on how many steps and since the Chauffeur form is 4 steps while Operating Authority is 6 steps, I hade to change the width.tia
tooa