-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fund status table to Data Dictionary with funding status descriptions #1507
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
92698e7
add fund status to settings
mateoclarke 76ee8be
add fund status to table query
mateoclarke 51afa71
Add funding_status_description via migration with metadata permission…
mateoclarke bd5df22
🤖 Export view for 19665_fund_status_data_dictionary
ab9bcfc
fix indentation
mateoclarke ea5ed9e
add comment to query
mateoclarke faa2ac5
PR feedback
mateoclarke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
moped-database/migrations/1735340549358_add-funding-status-description/down.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
-- Remove the funding_status_description column | ||
ALTER TABLE "public"."moped_fund_status" | ||
DROP COLUMN "funding_status_description"; |
14 changes: 14 additions & 0 deletions
14
moped-database/migrations/1735340549358_add-funding-status-description/up.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
ALTER TABLE "public"."moped_fund_status" | ||
ADD COLUMN "funding_status_description" text NULL; | ||
|
||
COMMENT ON COLUMN "public"."moped_fund_status"."funding_status_description" IS 'Description of the funding status'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🥇 |
||
|
||
UPDATE "public"."moped_fund_status" | ||
SET "funding_status_description" = CASE "funding_status_name" | ||
WHEN 'Tentative' THEN 'In conversation about possible funding commitment' | ||
WHEN 'Confirmed' THEN 'Commitment to funding' | ||
WHEN 'Available' THEN 'Funding is available, e.g. private developer' | ||
WHEN 'Funding setup requested' THEN 'Requested that funding be set up in eCAPRIS' | ||
WHEN 'Set up' THEN 'Funding has been set up in eCAPRIS; has FDU' | ||
ELSE "funding_status_description" | ||
END; | ||
mddilley marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this migration simple since it didn't seem like this table is a prereq for the db views that power the advanced search component on the Projects index page. Since fund status isn't an option as an advanced filter field, this seemed right, but I may be naive.