-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate subproject funding modal to DataGridPro #1517
Conversation
* User Hook | ||
* @type {object} CognitoUserSession | ||
*/ | ||
const { user } = useUser(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This user data was retrieved to be passed to the SubprojectFundingModal component where it was no longer used in the funding source mutation.
onSelectionChange={(rows) => setSelectedFdus(rows)} | ||
pagination | ||
pageSizeOptions={[PAGE_SIZE]} | ||
hideFooter={filteredData.length < PAGE_SIZE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda like how pagination shows you how many record options there are. Not sure how helpful that is in the real world.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I also think i prefer the pagination visible all the time. in addition to the record count i like when it's disabled on-screen because it's a little hint that sometimes there may be a lot of rows in the table.
lately i have been feeling down about hidden functionality in general—i feel like it leads to an inconsistent UX and maybe more bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree with john and mateo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome y'all - thanks! I removed the conditional render. 🗑️ 👋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how common this use case is but if you switch your eCapris ID, the old funding sources added from the previous eCAPRIS ID persist. I could see a world where those would get removed if the eCAPRIS ID no longer matches. But I'm probably overthinking that use case.
Overall, works just as described in testing steps.
onSelectionChange={(rows) => setSelectedFdus(rows)} | ||
pagination | ||
pageSizeOptions={[PAGE_SIZE]} | ||
hideFooter={filteredData.length < PAGE_SIZE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda like how pagination shows you how many record options there are. Not sure how helpful that is in the real world.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another one bites the dust—looks great! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks and works great! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welcome to the datagrid pro world!
Associated issues
Closes cityofaustin/atd-data-tech#18179
This PR migrates the eCapris subproject funding source table in the "FROM ECAPRIS" modal to use DataGridPro.
Testing
URL to test:
Local or deploy preview
Steps to test:
This table fetches rows from an open dataset by the eCapris subproject ID set on a project. Some IDs match many results while other only match a few so you can use both 11280.006 which will show 18 rows in the table and 7333.001 which will show 4 rows in the table.
You can find other eCapris subproject IDs to test using this query on the open dataset - you just have to remove the comma in the
SP_NUMBER_TXT
column.11280.006
as the eCapris subproject ID in the project summary view or in the Funding tab.7333.001
to see how the table hides pagination if there are 10 or less rows in the table.Ship list
[ ] Product manager added to QA test script if applicable