Move temporary records functionality to crashes list

[roseeichelmann]

Associated issues

Closes cityofaustin/atd-data-tech#20469

Testing

URL to test:
Local or netlify

Steps to test:

1. Observe that the Create crash page has been removed from the sidebar and no longer exists
2. Navigate to the Crashes page, see that you can now filter the list to only show temporary records by flipping on the radio button in the filters
3. Test turning on/off the temp records filter, use it in conjunction with other filters
4. Click the create crash record button, add a crash with units and injuries/fatalities. See that a refetch happens on save and the crash is added to the list.
5. Test using the private drive crashes filter by making one of the temp crashes a private drive crash. Flip on the temporary records button to only show tempc rashes. Make sure that the crash doesnt show up until you turn on "Include private drive crashes".

---

Ship list

• Check migrations for any conflicts with latest migrations in main branch
• Confirm Hasura role permissions for necessary access
• Code reviewed
• Product manager approved

[netlify]

✅ Deploy Preview for vision-zero-nextjs ready!

Name	Link
🔨 Latest commit	3aed280
🔍 Latest deploy log	https://app.netlify.com/sites/vision-zero-nextjs/deploys/67859040b4fcd20008a87ce7
😎 Deploy Preview	https://deploy-preview-1654--vision-zero-nextjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[johnclary]

👍 🙏

[johnclary]

@roseeichelmann thanks for making such quick work of this—it looks fantastic! One small thing: when you delete a temp crash, the CrashIsTemporaryBanner is still routing to the old /create-crash-record page. that can be updated to /crashes.

[roseeichelmann]

@johnclary such a great catch, just fixed this!

[johnclary]

🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢

[frankhereford]

This fulfills the request on the issue perfectly -- 💯. Code looks great too -- thank you for this Rose!

My only suggestion is micro, and is related only to the label of the new filter and not the functionality. As is, though, this is plenty shippable. 🚢🚢🚢🚢

[frankhereford]

This is totally outside the scope of this PR, but while I was reviewing it, a typo jumped out at me in this file. Would you mind adding a space to the comment /** Check local storage for initialsidebar state */ on line 42? No big if not!!

[frankhereford]

What would you think about adding the word "Only" to the label here, so it reads "Only temporary records?" The idea being that the two internal filters have a very different interaction to the existing set.

"Include private drive crashes" adds to the existing set by allowing in more crashes, and "Temporary records" is unclear if it's going to limit to just temporary records or allow the temporary records to be added to the existing set being shown.

Because it ends up doing a different operation (limit as opposed to add-to) as the previous option, I think adding a verb to the label can help the user get the right expectation.

I feel like I've done a really poor job in explaining my rational - LMK if i can help explain any of this better.

---

Edit: I was reading more of this as I reviewed, and you pointed out how the one above is _and and this one is still an _or. They are the right operations, of course -- we just need to broadcast that nuance in the labels to the user.