Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users page: copy user email addresses #1660

Open
wants to merge 4 commits into
base: nextjs
Choose a base branch
from

Conversation

roseeichelmann
Copy link
Contributor

@roseeichelmann roseeichelmann commented Jan 15, 2025

Associated issues

Closes cityofaustin/atd-data-tech#20121

Testing

URL to test:
Local - you will need to run the users api and also update isValidUser in api/server.py to return true until john gets rid of that function

Steps to test:

  1. Go to the users page. While the users are loading you should see a spinner and not see the buttons. Once the users load, you see the buttons.
  2. Click on the copy emails button, check that they copied to your clipboard. Make sure test accounts arent being included.
  3. Navigate to crashes and back to users. While isValidating is true there will be a spinner by the buttons and they should be disabled.

Ship list

  • Check migrations for any conflicts with latest migrations in main branch
  • Confirm Hasura role permissions for necessary access
  • Code reviewed
  • Product manager approved

@roseeichelmann roseeichelmann added the WIP Work in progress label Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for vision-zero-nextjs ready!

Name Link
🔨 Latest commit 11fc4a9
🔍 Latest deploy log https://app.netlify.com/sites/vision-zero-nextjs/deploys/678838a2b044990008730c1f
😎 Deploy Preview https://deploy-preview-1660--vision-zero-nextjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for vision-zero-nextjs ready!

Name Link
🔨 Latest commit feea107
🔍 Latest deploy log https://app.netlify.com/sites/vision-zero-nextjs/deploys/67895163786ad9000822262d
😎 Deploy Preview https://deploy-preview-1660--vision-zero-nextjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -48,21 +68,29 @@ export default function Users() {
<Button
className="me-2"
onClick={() => setShowNewUserModal(true)}
disabled={isValidating}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable the buttons while we are showing the isValidating spinner (different from the isLoading spinner which is for loading all the users in the table)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant