Fix test / possible live error on submitting credit card renewals

[eileenmcnaughton]

Overview

Fix intermittent error on credit card renewal by credit card

Before

Intermittent ? fail

After

No fail

Technical Details

In the course of fixing #14315 I found that I was getting test failures due to the contribution having no receive_date - this is carried over as trxn_date to the financialTrxn date and fatals.

I was able to replicate in the UI renewing with a dummy processor - but I suspect there must be some factor that makes this intermittent despite it seeming reliable for me. I have a feeling I've seen it as an intermittent error on jenkins

We 'know' that the receive_date is 'now' if we are paying by card so this should be safe

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[mattwire]

This doesn't really seem like something we should be passing in on each form and instead should be getting a default somewhere. However, the MembershipRenewal form is pretty toxic so as this helps consistency I'll merge.

[eileenmcnaughton]

@mattwire are you meaning the BAO_Contribution create method should default to 'now' if no receive_date is set? That makes sense I think