-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Riverlea theme extension during CiviCRM build #31315
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
woohoo - although @totten might need to look |
Added But it's failed complaining about backdrop_php5 - which is weird. Seems unrelated. Also sure php5 was dead long before Backdrop existed? |
Oh it can't apply the patch in the PR to that file. Can you try rebase maybe @vingle ? |
@ufundo and they all have php5 in the title - maybe it means more like 'high five php!' :) But not sure it's linked to the failures.. the bit I'm wondering about is how/where it knows that the riverlea in Answering my own question - I wonder if it's this line? civicrm-core/distmaker/dists/common.sh Line 328 in 00b5091
|
I think the error is in how the Jenkins job applies the PR changes to the main branch, in order to run the test -- before it gets as far as downloading any extensions or anything... |
@vingle It looks like your patch is against the 5.77 version of the file - the file has changed since then so you need to apply the change against a newer version, preferably master since your PR is against master. |
@demeritcowboy odd I thought I'd rebased. Will do, thanks. |
Have opened a new PR #31324 so closing this. |
Overview
Following discussion this packages the most recent release of the RiverLea theme framework extension (https://lab.civicrm.org/extensions/riverlea) during the CiviCRM build process.
Before
RiverLea isn't packaged, so needs to be installed manually.
After
It is. Anyone can enable RiverLea to try one of its four subthemes/'streams'.
Technical Details
RiverLea is a large extension. To better understand it, a good starting point is to look at the GitLab readme, changelog, issues, & PR history.
Comments
I am kind of guessing this is the right way to add this, but cannot test.