Package Riverlea theme extension during CiviCRM build

[vingle]

Overview

Following discussion this packages the most recent release of the RiverLea theme framework extension (https://lab.civicrm.org/extensions/riverlea) during the CiviCRM build process.

Before

RiverLea isn't packaged, so needs to be installed manually.

After

It is. Anyone can enable RiverLea to try one of its four subthemes/'streams'.

Technical Details

RiverLea is a large extension. To better understand it, a good starting point is to look at the GitLab readme, changelog, issues, & PR history.

Comments

I am kind of guessing this is the right way to add this, but cannot test.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

woohoo - although @totten might need to look

[ufundo]

Added run-distmaker to make testable install packages.

But it's failed complaining about backdrop_php5 - which is weird. Seems unrelated. Also sure php5 was dead long before Backdrop existed?

[ufundo]

Oh it can't apply the patch in the PR to that file. Can you try rebase maybe @vingle ?

[vingle]

@ufundo and they all have php5 in the title - maybe it means more like 'high five php!' :) But not sure it's linked to the failures.. the bit I'm wondering about is how/where it knows that the riverlea in dm_install_cvext riverlea "$TRG/ext/riverlea" refers to a specific repo somewhere.

Answering my own question - I wonder if it's this line?

civicrm-core/distmaker/dists/common.sh

Line 328 in 00b5091

cv dl -b "@https://civicrm.org/extdir/ver=$DM_VERSION/$1.xml" --to="$2"

- in which case I wonder if the errror is that this doesn't resolve to RiverLea? Not sure how https://civicrm.org/extdir is generated but maybe it comes from /extensions?

[ufundo]

I think the error is in how the Jenkins job applies the PR changes to the main branch, in order to run the test -- before it gets as far as downloading any extensions or anything...

[demeritcowboy]

@vingle It looks like your patch is against the 5.77 version of the file - the file has changed since then so you need to apply the change against a newer version, preferably master since your PR is against master.

[vingle]

@demeritcowboy odd I thought I'd rebased. Will do, thanks.

[vingle]

Have opened a new PR #31324 so closing this.