Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19542 Unable to theme language switcher block #426

Open
wants to merge 1 commit into
base: 7.x-master
Choose a base branch
from
Open

CRM-19542 Unable to theme language switcher block #426

wants to merge 1 commit into from

Conversation

kainuk
Copy link
Contributor

@kainuk kainuk commented Feb 6, 2017

@colemanw
Copy link
Member

colemanw commented Feb 6, 2017

@mlutfy do you use this block? Could you please test this patch to ensure it doesn't cause any regression?

@jackrabbithanna
Copy link
Contributor

well that patch does make sense

if you can get the same behavior with a preprocess, why have your own theme function, and override the theme registry to use it?

I think this patch may be the way to go, but we need to figure out a way to test if it breaks themes....

@kainuk what theme do you use?

@jackrabbithanna
Copy link
Contributor

actually it shouldn't matter what theme.

it just needs to be tested in a multilingual drupal + multilingual civicrm site, with the Drupal language switcher block placed on civicrm pages

@mlutfy
Copy link
Member

mlutfy commented Aug 23, 2017

I tested this on some sites, but it didn't work: clicking on the language block (from a page in French) would give me an URL such as: https://demo.symbiotic.coop/fr/civicrm/contribute/transact?q=en/civicrm/contribute/transact&reset=1&id=1

@kainuk Had this been tested on a multi-lingual site? (with locale+i18n)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants