Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRM-21347 Joomla auto-save of features fails #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twomice
Copy link

@twomice twomice commented Oct 24, 2017

I think JHTML::_() needs separate arguments rather than an array of named parameters. This at least matches what I see in other Joomla code, and it works to solve the problem.


I think JHTML::_() needs separate arguments rather than an array of named parameters. This at least matches what I see in other Joomla code, and it works to solve the problem.
@andrewpthompson
Copy link
Contributor

@twomice I realise this is a pretty old PR! I haven't looked at the problem but the change doesn't look quite right to me.

I found a number of places in Joomla's core where an array is passed into JHtml::_(), for example:

The Joomla API docs show that the second and third paramaters should be arrays not bools. (The JHtml::_() class loader should pass the arguments to JHtml::script() if I understand correctly.)

@twomice
Copy link
Author

twomice commented Jan 18, 2019

Thanks, @andrewpthompson Joomla development is not my strong suit. If you care to make changes to the PR, that would be great.

But on another note, I wonder if the original issue is even still relevant. Before spending more time on this, I think one would want to see if the original issue (CRM-21347) is still happening in the latest versions of CiviCRM and Joomla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants