Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW-379: Fixed minor css issue for dashlet #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mukeshcompucorp
Copy link
Contributor

Before:
screenshot-3 1
screenshot-7
screenshot-4 1
screenshot-6

After:
after
after-2

@colemanw
Copy link
Member

I can't really tell the difference with the arrow - is it just that the point is now slightly rounded? That's a lot of extra markup for such a subtle effect. Is the css arrow class something standard in bootstrap? Otherwise we probably ought to prefix it. In general we should avoid making very generic class names to avoid conflicts with the cms theme, etc.

@mukeshcompucorp
Copy link
Contributor Author

@colemanw yes, this is something we need to add,
see https://github.com/civicrm/org.civicrm.civicase/pull/82/files#diff-9033655017b6c074bdd78d6eb6f1a3a6R7 This part is also essential here to have arrow color properly as per activity.case.status.color which we can not give in :after pseudo element.
Also, from previous solution simply adding border-radius does not work.
Though, if we need we can change that class to something like case-arrow if that makes it less conflict with cms

position: relative;
}
#bootstrap-theme .act-feed-item a.act-case-info span:first-child:after {
#bootstrap-theme .act-feed-item a.act-case-info span:first-child span.arrow {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the simplicity of the previous css using :after but if you want to define a new element let's do it properly. Give it a name like civicase-crayon-tip and define it in its own right (there's no need for the specificity of .act-feed-item a.act-case-info span:first-child since a generic css element ought to work anywhere not just in that one place.

swastikpareek added a commit to swastikpareek/org.civicrm.civicase that referenced this pull request Oct 22, 2019
…ail-design

C51-268: Contact Case Tab detail section implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants