Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Image upload field processing on volunteer signup form #519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pradpnayak
Copy link
Contributor

@ginkgomzd
Copy link
Contributor

ginkgomzd commented Sep 5, 2019

I replied on the SE thread.
This PR looks fine, but I'd like to understand what is going on.
Right now, this is looking to be caused by a change in core, so I'd like to know what version the change was introduced. In particular, is this fix backwards compatible? I can go check that right now...
After trying the patch, and looking more closely at the profile, I am leaning towards this being an instance configuration issue (or permissions? or caches?). I see that the profile should automatically adapt to an upload-type submit with the presence of a file-field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants