Add a retry for downloading files via civis.io.file_to_civis #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also fixes a related bug in file_to_civis where the buffer was reset to 0 rather than the original position when retrying.
mheilman
changed the title
mheilman
changed the title
jkulzick
approved these changes
Nov 30, 2018
| buf_orig_position = buf.tell() | ||
|
|
||
| @retry(RETRY_EXCEPTIONS) | ||
| def _download_url_to_buf(): |
There was a problem hiding this comment.
Another way to do this without re-downloading the bytes you already retrieved is to use range headers in the HTTP Get request like so. You can probably do something similar on Put but I haven't done that before.
Up to you...
There was a problem hiding this comment.
That's a good idea, but I'm going to punt on it for now. I filed #274.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also fixes a related bug in file_to_civis where the buffer was reset to 0 rather than the original position when retrying.
Fixes #272.