Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set network_id required as true in resource_instance.go file #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dipu989
Copy link

@dipu989 dipu989 commented Oct 21, 2024

Ticket link

Please check the issue description for the context.

@dipu989
Copy link
Author

dipu989 commented Oct 21, 2024

@uzaxirr @alessandroargentieri
Please review.

@uzaxirr
Copy link
Member

uzaxirr commented Oct 22, 2024

Can you attach an screenshot where you are using local build of your TF provider and you are doing terraform apply on an instance resource where network_id is not mentioned and your provider is throwing up an error. You can refer this to build and test your TF provider locally

@dipu989
Copy link
Author

dipu989 commented Oct 22, 2024

@uzaxirr Sure, let me take a look at the docs. Will test it out and post the results here.

@dipu989
Copy link
Author

dipu989 commented Oct 24, 2024

@uzaxirr Seems like changing network_id to true is not helping in the case here.

But I tried setting the current mandatory field i.e disk_image to Optional : true and built the provider and did terraform apply -> It still says that disk_image is required but not definition is found.
Which means either I am missing some crucial step or not setting the correct binary path or not building the provider correctly after making changes.

Here's the command I am executing after making changes in resource_instance.go code in provider.
Also printed $GOPATH and ls in the directory to confirm that binary is there as shared in the screenshot.

image

Can you point me where I might be going wrong? That would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants