Streaming uploads revisited #180
Open
+114
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't leave it hanging...
|
is the progress bar compatible with LocalCKAN (or ckanapi -c)? If not the switch should be moved together with the |
|
Can we move |
wardi
reviewed
Feb 1, 2022
| @@ -16,8 +16,8 @@ def __init__(self, expected_name, expected_args, response, | |||
| self._expected_files = expected_files or {} | |||
| self._response = response | |||
|
|
|||
| def call_action(self, name, args, context=None, apikey=None, files=None, | |||
| requests_kwargs=None): | |||
| def call_action(self, name, args, context=None, apikey=None, progress=None, | |||
There was a problem hiding this comment.
new parameters at the end, just in case
wardi
reviewed
Feb 1, 2022
| @@ -79,7 +97,8 @@ def prepare_action(action, data_dict=None, apikey=None, files=None): | |||
| continue # assuming missing will work the same as None | |||
| if isinstance(v, (int, float)): | |||
| v = str(v) | |||
| data_dict[k.encode('utf-8')] = v.encode('utf-8') | |||
| #data_dict[k.encode('utf-8')] = v.encode('utf-8') | |||
There was a problem hiding this comment.
Suggested change
| #data_dict[k.encode('utf-8')] = v.encode('utf-8') |
wardi
reviewed
Feb 1, 2022
| elif type(s) == unicode: | ||
| return s.encode('utf-8') # It is PY2 :class:unicode | ||
| else: | ||
| return s.decode('utf-8').encode('utf-8') #type(s) is PY2<str> or illegal |
There was a problem hiding this comment.
is this just to raise an error for invalid types?
|
Would be nice to have a test for this functionality as well. |
|
Hi guys! I'm a quite new ckan user / dev. And I was wondering if there's any plan to merge this soon? Cheers! |
|
@ChristianF88 there are some small things to fix I pointed out above, and some new conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @wardi. Happy New Year!
I adapted @hvwaldow's old streaming uploads PR (#109), and can confirm it works like a charm!
Exercised it heavily with multi-gigabyte uploads both from the CLI and as a python module, and it performs as expected.
Submitting the PR again as I think it will be a valuable addition to ckanapi (and I'd rather not maintain my own fork :) ).