Merge pull request #533 from GovDataOfficial/fix-harvest-error-dictiz…

…ation Adapt template to latest changes in harvest job error dictization
ckan · Jun 1, 2023 · 02aeaf4 · 02aeaf4
2 parents b244216 + ec57de3
commit 02aeaf4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/ckanext/harvest/templates/snippets/job_error_summary.html b/ckanext/harvest/templates/snippets/job_error_summary.html
@@ -1,7 +1,7 @@
 {#
 Displays a table with a summary of the most common errors for a job
 
-error_summary        - List of tuples with (message, count)
+error_summary        - List of dicts with message and error_count
 
 Example:
 
@@ -22,8 +22,8 @@
   <tbody>
   {% for error in summary %}
     <tr>
-      <td class="count">{{ error[1] }}</td>
-      <td>{{ error[0] }}</td>
+      <td class="count">{{ error["error_count"] }}</td>
+      <td>{{ error["message"] }}</td>
     </tr>
   {% endfor %}
    </tbody>

diff --git a/ckanext/harvest/tests/test_action.py b/ckanext/harvest/tests/test_action.py
@@ -783,5 +783,7 @@ def test_harvest_source_show_status(self):
         assert last_job['stats']['errored'] == 2
         assert len(last_job['object_error_summary']) == 1
         assert last_job['object_error_summary'][0]['message'] == harvest_object_error.message
+        assert last_job['object_error_summary'][0]['error_count'] == 1
         assert len(last_job['gather_error_summary']) == 1
         assert last_job['gather_error_summary'][0]['message'] == harvest_gather_error.message
+        assert last_job['gather_error_summary'][0]['error_count'] == 1