Fix output validators parsing when repeating_subfields #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error
Currently if
repeating_subfields
are used with anoutput_validator
, then an error is raised during validator concatenation:Issue
The source of the error (trying to add dict subfield validators to list of field validators):
ckanext-scheming/ckanext/scheming/plugins.py
Lines 576 to 578 in 8646a9d
Solution
This PR adds a type check and appends the field validator as a list if no subfields, or as a dict if subfields: