Support for CKAN 2.11 #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from CKAN 2.11 test client calls are authenticated via
`headers={"Authorization": token}` rather than
`environ_overrides={"Authorization": token}`. Created some helper
functions to handle different CKAN versions from a single place. Also
there is a new form in the page so index-based selectors needed to be
updated.
amercader
commented
Jun 13, 2024
.github/workflows/test.yml
Outdated
| @@ -17,13 +17,13 @@ jobs: | |||
| needs: lint | |||
| strategy: | |||
| matrix: | |||
| ckan-version: ["2.10", "2.9", "2.9-py2"] | |||
| ckan-version: ["master", "2.10", "2.9"] | |||
There was a problem hiding this comment.
Using master for now as the ckan/ckan-dev:2.11 images are not yet built
wardi
approved these changes
Jun 13, 2024
This was referenced Jun 14, 2024
wardi
reviewed
Jun 27, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| needs: lint | |||
| strategy: | |||
| matrix: | |||
| ckan-version: ["master", "2.10", "2.9"] | |||
| ckan-version: ["2.11", "2.10", "2.9"] | |||
There was a problem hiding this comment.
don't want to keep testing against master?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freshen up the worflow file and adapt tests to changes in test client authentication in CKAN 2.11
Starting from CKAN 2.11 test client calls are authenticated via
headers={"Authorization": token}rather thanenviron_overrides={"Authorization": token}. I added some helper functions to handle different CKAN versions from a single place. Also there is a new form in the page so index-based selectors needed to be updated.More details on the auth changes here:
https://github.com/ckan/ckan/wiki/CKAN-2.10-to-2.11-migration-tips#authentication-when-using-the-test-client