New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False is also a value #417

Open

avdata99 wants to merge 2 commits into ckan:master from avdata99:cover_false

Member

avdata99 commented Jun 27, 2024 •

edited

Loading

In a field with boolean values like this

- field_name: some_bool
  label: Some Bool
  required: false
  preset: select
  choices:
    - value: false
      label: "No"
    - value: true
      label: "Yes"
  validators: scheming_required boolean_validator
  output_validators: boolean_validator

and if the false value is selected, we didn't display anything in the select

This PR fixes those cases

avdata99 added 2 commits

June 27, 2024 15:07


          False is also a value

460240f


          Improve false detection

1341c40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet