Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pointer types correctly #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions intrange.go
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,8 @@ func recursiveOperandToString(
return recursiveOperandToString(e.X, false) + "[" + recursiveOperandToString(e.Index, false) + "]"
case *ast.BinaryExpr:
return recursiveOperandToString(e.X, false) + " " + e.Op.String() + " " + recursiveOperandToString(e.Y, false)
case *ast.StarExpr:
return "*" + recursiveOperandToString(e.X, false)
default:
return ""
}
Expand Down
16 changes: 16 additions & 0 deletions testdata/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -663,3 +663,19 @@ func issue33() {
for i = 0; i < 10; i++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)\nBecause the key is not part of the loop's scope, take care to consider side effects.`
}
}

func issue50() {
x := 10
i := &x
for k := 0; k < int(*i); k++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}

for k := int(0); k < int(*i); k++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}

for k := 0; k < *i; k++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}

for k := int32(0); k < int32(*i); k++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}
}
16 changes: 16 additions & 0 deletions testdata/main.go.golden
Original file line number Diff line number Diff line change
Expand Up @@ -663,3 +663,19 @@ func issue33() {
for i = 0; i < 10; i++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)\nBecause the key is not part of the loop's scope, take care to consider side effects.`
}
}

func issue50() {
x := 10
i := &x
for range *i { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}

for range *i { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}

for range *i { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}

for range int32(*i) { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
}
}
Loading