Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ckeditor5-dev-tests to ESM #1009

Merged
merged 19 commits into from
Sep 19, 2024
Merged

Convert ckeditor5-dev-tests to ESM #1009

merged 19 commits into from
Sep 19, 2024

Conversation

pomek
Copy link
Member

@pomek pomek commented Sep 16, 2024

Suggested merge commit message (convention)

Internal (tests): Converted the ckeditor5-dev-tests package to ESM.

Internal: The ckeditor5-dev repository is now marked as a module.

Internal: Redesigned the CI flow. Now, each package test runner is defined in a dedicated step instead of as a whole.

MAJOR BREAKING CHANGE (tests): The IntelliJ Karma configuration path needs to be updated. Now it ends with the cjs suffix instead of js.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pomek pomek changed the base branch from master to epic/3757-esm September 16, 2024 09:58
@pomek pomek marked this pull request as ready for review September 18, 2024 11:55
@pomek pomek requested a review from psmyrek September 18, 2024 11:56
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked automated and manual tests and it looks like they work fine.

LGTM 🎉

@pomek pomek merged commit d89e126 into epic/3757-esm Sep 19, 2024
5 checks passed
@pomek pomek deleted the i/3765-tests branch September 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants