Improvements for the "publishPackages()" task #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error after trying to publish packages after reaching an attempted limit. Instead, it should verify if the last try was successfully completed. If it wasn't, throw the error. Other (release-tools): Increased the attemptions limit from 3 to 5.
…y the "pacote" package ("manifest()", "packument()"). It prevents from using any cache when checking the npm registry.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (release-tools): The
publishPackages()task should not throw an error after trying to publish packages after reaching an attempted limit. Instead, it should verify if the last try was successfully completed and throw the error if it wasn't. Closes ckeditor/ckeditor5#17333.Other (release-tools): Increased the attempts limit from 3 to 5.
Other (release-tools): Created a decorated version of utils (
manifest(),packument()) exposed by thepacotepackage. It prevents from using any cache when checking the npm registry. Direct calls have been replaced with the decorated version.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.