Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (build-tools): Always enable TypeScript plugin, even when declarations is set to false. #1051

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix (build-tools): Always enable TypeScript plugin, even when declarations is set to false. #1051

merged 2 commits into from
Dec 18, 2024

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Dec 17, 2024 •
edited
Loading

Suggested merge commit message (convention)

Fix (build-tools): Always enable the TypeScript plugin, even when declarations is set to false. Fixes ckeditor/ckeditor5#17653.

@coveralls
Copy link

Coverage Status

coverage: 88.001% (-0.002%) from 88.003%
when pulling abcc8c2 on always-use-typescript-plugin-in-build-tools
into e9f9d41 on master.

pomek
pomek approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@filipsobol filipsobol merged commit 86f5db1 into master Dec 18, 2024
7 checks passed
@filipsobol filipsobol deleted the always-use-typescript-plugin-in-build-tools branch December 18, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tree-shaking regression in the latest nightly
3 participants
@filipsobol @coveralls @pomek