-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused utils #994
Merged
Merged
Removed unused utils #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
commented
Aug 29, 2024
packages/ckeditor5-dev-tests/lib/utils/automated-tests/parsearguments.js
Outdated
Show resolved
Hide resolved
pomek
force-pushed
the
ci/3746-unused-utils
branch
from
August 29, 2024 19:04
627fa19
to
a109d05
Compare
psmyrek
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Added several missing
dependencies
anddevDependencies
in packages. Also, removed non-used ones.Other (dependency-checker): The dependency checker includes the
lib/
andbin/
directories as a production code when analyzing dependencies.Internal: Created a test script that executed tests from all packages one by one instead of merging each test into a single process.
Internal: Improved the CI machines to speed up the builds.
Other (utils): Removed several utilities functions non-used in the CKEditor 5 environment.
MAJOR BREAKING CHANGE (utils): The
git
andworkspace
objects are no longer exported from the package. Also, the following functions are no longer available in thetools
object:isDirectory()
isFile()
isSymlink()
sortObject()
readPackageName()
npmInstall()
npmUninstall()
npmUpdate()
copyTemplateFile()
copyFile()
getGitUrlFromNpm()
removeSymlink()
clean()
Additional information
See: cksource/ckeditor5-internal#3746