Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused utils #994

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Removed unused utils #994

merged 8 commits into from
Aug 30, 2024

Conversation

pomek
Copy link
Member

@pomek pomek commented Aug 29, 2024

Suggested merge commit message (convention)

Other: Added several missing dependencies and devDependencies in packages. Also, removed non-used ones.

Other (dependency-checker): The dependency checker includes the lib/ and bin/ directories as a production code when analyzing dependencies.

Internal: Created a test script that executed tests from all packages one by one instead of merging each test into a single process.

Internal: Improved the CI machines to speed up the builds.

Other (utils): Removed several utilities functions non-used in the CKEditor 5 environment.

MAJOR BREAKING CHANGE (utils): The git and workspace objects are no longer exported from the package. Also, the following functions are no longer available in the tools object:

  • isDirectory()
  • isFile()
  • isSymlink()
  • sortObject()
  • readPackageName()
  • npmInstall()
  • npmUninstall()
  • npmUpdate()
  • copyTemplateFile()
  • copyFile()
  • getGitUrlFromNpm()
  • removeSymlink()
  • clean()

Additional information

See: cksource/ckeditor5-internal#3746

@pomek pomek marked this pull request as draft August 29, 2024 11:54
@pomek pomek force-pushed the ci/3746-unused-utils branch from 627fa19 to a109d05 Compare August 29, 2024 19:04
@coveralls
Copy link

coveralls commented Aug 30, 2024

Coverage Status

coverage: 91.041% (+0.2%) from 90.797%
when pulling d102ba4 on ci/3746-unused-utils
into 848ff18 on master.

@pomek pomek marked this pull request as ready for review August 30, 2024 10:24
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@pomek pomek merged commit e84c701 into master Aug 30, 2024
6 checks passed
@pomek pomek deleted the ci/3746-unused-utils branch August 30, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants