Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CDN integration and shared utils to package #1

Merged
merged 5 commits into from
Aug 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ commands:
CKE5_GITHUB_ORGANIZATION="ckeditor"
CKE5_GITHUB_REPOSITORY="ckeditor5-integrations-common"
CKE5_CIRCLE_APPROVAL_JOB_NAME="release_approval"
CKE5_GITHUB_RELEASE_BRANCH="main"
CKE5_GITHUB_RELEASE_BRANCH="master"

echo export CKE5_CIRCLE_APPROVAL_JOB_NAME=$CKE5_CIRCLE_APPROVAL_JOB_NAME >> $BASH_ENV
echo export CKE5_GITHUB_RELEASE_BRANCH=$CKE5_GITHUB_RELEASE_BRANCH >> $BASH_ENV
Expand Down Expand Up @@ -110,13 +110,13 @@ jobs:
- prepare_environment_command
- run:
name: Execute ESLint
command: npm run lint
command: yarn lint
- run:
name: Run build
command: npm run build
command: yarn build
- run:
name: Run unit tests
command: npm run test
command: yarn test
- run:
name: Verify the code coverage
command: |
Expand Down Expand Up @@ -192,11 +192,11 @@ jobs:
command: |
#!/bin/bash

CKE5_LATEST_COMMIT_HASH=$( git log -n 1 --pretty=format:%H origin/main )
CKE5_LATEST_COMMIT_HASH=$( git log -n 1 --pretty=format:%H origin/master )
CKE5_TRIGGER_COMMIT_HASH=<< pipeline.parameters.triggerCommitHash >>

if [[ "${CKE5_LATEST_COMMIT_HASH}" != "${CKE5_TRIGGER_COMMIT_HASH}" ]]; then
echo "There is a newer commit in the repository on the \`#main\` branch. Use its build to start the release."
echo "There is a newer commit in the repository on the \`#master\` branch. Use its build to start the release."
circleci-agent step halt
fi
- npm_login_command
Expand Down Expand Up @@ -256,12 +256,12 @@ workflows:
filters:
branches:
only:
- main
- master
- notify_ci_failure:
filters:
branches:
only:
- main
- master

release:
when:
Expand All @@ -287,4 +287,4 @@ workflows:
filters:
branches:
only:
- main
- master
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,8 @@ dist/
.idea
.tmp
/release/
.vscode/
*.log
vite.config.ts.timestamp-*
vite.test-utils.config.ts.timestamp-*
vitest.config.ts.timestamp-*
3 changes: 3 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
# Copyright (c) 2003-2024, CKSource Holding sp. z o.o. All rights reserved.
# For licensing, see LICENSE.md.

npx lint-staged
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
21.7
20
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
# CKEditor 5 - Common Integration Utils

[![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-intergations-common.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-intergations-common)
[![CircleCI](https://circleci.com/gh/ckeditor/ckeditor5-intergations-common.svg?style=shield)](https://app.circleci.com/pipelines/github/ckeditor/ckeditor5-intergations-common?branch=main)
[![Coverage Status](https://coveralls.io/repos/github/ckeditor/ckeditor5-intergations-common/badge.svg?branch=main)](https://coveralls.io/github/ckeditor/ckeditor5-intergations-common?branch=main)
[![CircleCI](https://circleci.com/gh/ckeditor/ckeditor5-integrations-common.svg?style=shield)](https://app.circleci.com/pipelines/github/ckeditor/ckeditor5-integrations-common?branch=master)
[![Coverage Status](https://coveralls.io/repos/github/ckeditor/ckeditor5-intergations-common/badge.svg?branch=master)](https://coveralls.io/github/ckeditor/ckeditor5-intergations-common?branch=master)
![Dependency Status](https://img.shields.io/librariesio/release/npm/@ckeditor/ckeditor5-intergations-common)

Official [CKEditor 5](https://ckeditor.com/ckeditor-5/) common integration utils.
Mati365 marked this conversation as resolved.
Show resolved Hide resolved

## Contributing

After cloning this repository, install necessary dependencies:
After cloning this repository, install the necessary dependencies:

```bash
npm install
Expand Down
Loading