Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned to changes in ckeditor5-dev-translations repository #197

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Oct 28, 2024

Suggested merge commit message (convention)

Other: The generated package no longer integrates with the Transifex service. Thanks to that, a community can provide translation entries directly via pull requests.

MAJOR BREAKING CHANGE (generator): Removed the translations:collect, translations:download and translations:upload scripts from the generated package. Instead, the translations:synchronize and translations:validate scripts are introduced. These two new scripts do not provide an integration with Transifex service anymore, but they help preparing translation files (*.po files) which must be handled by the integrator himself.

MAJOR BREAKING CHANGE (tools): Removed the translations:collect, translations:download and translations:upload tasks. Instead, the translations:synchronize task is introduced. It helps preparing translation files (*.po files) in the generated package.


Additional information

This PR is based on the #196, so it targets the ci/3772 branch.

This PR requires ckeditor/ckeditor5-dev#1042.

PR with updates in the docs: ckeditor/ckeditor5#17338.

Closes cksource/ckeditor5-internal#3817.

Supported scopes

Aligned to changes in `ckeditor5-dev-translations` repository.
Base automatically changed from ci/3772 to master October 30, 2024 08:22
@psmyrek psmyrek marked this pull request as ready for review October 30, 2024 08:44
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit c812fa0 into master Oct 30, 2024
14 checks passed
@pomek pomek deleted the ci/3817 branch October 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants