Add retries to flaky multiroot semaphores tests. #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 934960b4-11e8-492d-a92b-e3dc929f3348Details
💛 - Coveralls |
gorzelinski
reviewed
Nov 14, 2024
gorzelinski
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Add
retryoption to flakymultiroottest, extend delay between assertions.Tests: Randomize the order of the tests, to prevent incorrect dependencies across tests.
Additional information
This test tests quite rare scenario when
setDatais being called when editor is not initialized. In theory - it is possible, but I haven't managed to reproduce this in the real world. At this moment, there were no reports about incorrect behavior, so it's safe enough to retry it a few times.