Hide tooltip without delay for instant tooltips.

ckeditor · Oct 18, 2024 · f9c7020 · f9c7020
1 parent edea934
commit f9c7020
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/packages/ckeditor5-ui/src/tooltipmanager.ts b/packages/ckeditor5-ui/src/tooltipmanager.ts
@@ -366,6 +366,14 @@ export default class TooltipManager extends /* #__PURE__ */ DomEmitterMixin() {
 			if ( isLeavingBalloon || ( descendantWithTooltip && descendantWithTooltip !== relatedDescendantWithTooltip ) ) {
 				this._pinTooltipDebounced.cancel();
 
+				// If the currently visible tooltip is instant, unpin it immediately.
+				if (
+					this._currentElementWithTooltip && this._currentElementWithTooltip.matches( '[data-cke-tooltip-instant]' ) ||
+					descendantWithTooltip && descendantWithTooltip.matches( '[data-cke-tooltip-instant]' )
+				) {
+					this._unpinTooltip();
+				}
+
 				this._unpinTooltipDebounced();
 			}
 		} else {

diff --git a/packages/ckeditor5-ui/tests/tooltip/tooltipmanager.js b/packages/ckeditor5-ui/tests/tooltip/tooltipmanager.js
@@ -712,6 +712,19 @@ describe( 'TooltipManager', () => {
 				sinon.assert.calledOnce( unpinSpy );
 			} );
 
+			it( 'should remove the tooltip immediately if the element has `data-cke-tooltip-instant` attribute', () => {
+				elements.a.dataset.ckeTooltipInstant = true;
+
+				utils.dispatchMouseEnter( elements.a );
+
+				sinon.assert.calledOnce( pinSpy );
+
+				unpinSpy = sinon.spy( tooltipManager.balloonPanelView, 'unpin' );
+				utils.dispatchMouseLeave( tooltipManager.balloonPanelView.element, elements.b );
+
+				sinon.assert.calledOnce( unpinSpy );
+			} );
+
 			it( 'should not work if the tooltip is currently pinned and the event target is different than the current element', () => {
 				utils.dispatchMouseEnter( elements.a );
 				utils.waitForTheTooltipToShow( clock );