Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early PoC of CKEditor5 inside a Shadow DOM. #16975

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6a11868
Early PoC of CKEditor5 inside a Shadow DOM.
niegowski Aug 26, 2024
b498a03
Merge branch 'refs/heads/master' into ck/shadow-poc
niegowski Aug 27, 2024
c10f714
Add support for drop target in a shadow DOM.
niegowski Aug 27, 2024
a2d80c0
The body collection in a shadow root. Listening for global events on …
niegowski Sep 2, 2024
c612671
CSS root properties should be translated to the host element.
niegowski Sep 3, 2024
97618c8
Marked shadow root places in code. Handling of block toolbar dragging.
niegowski Sep 3, 2024
b6ab662
Component focus handling.
niegowski Sep 3, 2024
3c1d883
Merge branch 'refs/heads/master' into ck/shadow-poc
niegowski Sep 6, 2024
fedf8be
Active element handling updated to work in shadow DOM.
niegowski Sep 6, 2024
d81a4db
Added some shadow helpers.
niegowski Sep 9, 2024
0c71edf
Added notes.
niegowski Sep 10, 2024
d6134b5
Merge branch 'refs/heads/master' into ck/shadow-poc
niegowski Sep 27, 2024
3ca2b7d
Merge branch 'refs/heads/master' into ck/shadow-poc
niegowski Oct 4, 2024
2ae8696
Fixed checking if some element is connected with the DOM document.
niegowski Oct 4, 2024
c744843
Avoid selection fixing on multiple table cells selection.
niegowski Oct 4, 2024
b9573d4
Fixed image resizer in shadow dom.
niegowski Oct 7, 2024
8b5daff
Code cleaning.
niegowski Oct 7, 2024
54a65fe
Updated focus handling.
niegowski Oct 7, 2024
97b974e
Active element fixes.
niegowski Oct 7, 2024
e1a8bdf
Added comment about toolbar focus cycling.
niegowski Oct 7, 2024
5a62869
Manual test clear.
niegowski Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added notes.
  • Loading branch information
niegowski committed Sep 10, 2024
commit 0c71edf0a1a0e64fdafa0636b542c8e85036fc22
Original file line number Diff line number Diff line change
@@ -86,6 +86,7 @@ export default class MutationObserver extends Observer {
this._domElements.add( domElement );

if ( this.isEnabled ) {
// TODO ShadowRoot - will this work if widget has its own Shadow DOM?
this._mutationObserver.observe( domElement, this._config );
}
}
1 change: 1 addition & 0 deletions packages/ckeditor5-widget/src/widgettoolbarrepository.ts
Original file line number Diff line number Diff line change
@@ -190,6 +190,7 @@ export default class WidgetToolbarRepository extends Plugin {
initialized: false
};

// TODO ShadowRoot - cycling toolbars does not work correctly
// Register the toolbar so it becomes available for Alt+F10 and Esc navigation.
editor.ui.addToolbar( toolbarView, {
isContextual: true,