Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store non-document operation with batches #17679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

scofalik
Copy link
Contributor

Suggested merge commit message (convention)

Other (engine): Do not store non-document operation with batches. This improves memory efficiency for huge documents. Closes #17678.


Additional information

To verify correctness of this change, I checked three things:

  • All places where we add applyOperation listener. All places except of two filter non-document operations. One place is legacy lists, I skipped it. Other place is in commercial repo. The listener can work like it does but I will create a PR to fix it. This confirms, that we generally do not care about these operations.
  • I checked uses of Batch#operations to see if there are risky places where we might check the contents of operations for reasons. We do it very rarely. The places where we do it, it is fine after the change.
  • I checked uses of Operation#batch. This property is practically not used.

…s improves memory efficiency for huge documents.
@scofalik scofalik requested a review from niegowski December 19, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not store non-document operation in batches
2 participants