Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView Replaced with Sticky Header List View & Material Dialog #32

Closed
wants to merge 6 commits into from

Conversation

ahornerr
Copy link

@ahornerr ahornerr commented May 8, 2015

Hello cketti,

I've modified the changelog library to use the MaterialDialog library, and switched the WebView out for a StickyHeaderListView (See the screenshot in my readme). You may want to modify some of my code to allow for customization (for example, being able to supply a custom sticky header view or a custom list item view).

@cketti
Copy link
Owner

cketti commented Jun 7, 2015

@ahornerr: Sorry for taking this long to respond. Thank you for the pull request!
However, my plans for this library go into an opposite direction. I want to remove all the UI code and create a core library that only contains the changelog resource logic. Then maybe a couple of libraries implementing different ways to present the data, e.g. using fragments or dialogs.

I'm keeping this pull request open to remind me to add your code to the sample project as one way to present the changelog.

@johnjohndoe
Copy link
Contributor

🚧

... I want to remove all the UI code and create a core library that only contains the changelog resource logic ...

@cketti Any progress on this topic?

@cketti
Copy link
Owner

cketti commented Feb 18, 2016

@johnjohndoe: Thanks for the reminder. I started work here: https://github.com/cketti/ckChangeLog/tree/version_2

Feel free to propose changes or submit pull requests against that branch.

@johnjohndoe
Copy link
Contributor

@cketti Thank you for the hint. I will review your work soon.

@johnjohndoe
Copy link
Contributor

@cketti What is the schedule for the release of version 2 of your library? I am looking forward to it. 🐹

@cketti
Copy link
Owner

cketti commented Jul 4, 2016

@johnjohndoe There's always something that seems to come up. If you'll be at the ART meetup this week there's a good chance we might be able to finish a release candidate.

@cketti
Copy link
Owner

cketti commented May 13, 2018

Hopefully it will be easy to build this upon version 2.0.0's core artifact. Please check out #39.

@cketti cketti closed this May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants