Break out into separate files, bundle with browserify, fix #11 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scommisso
force-pushed
the
master
branch
2 times, most recently
from
e291049 to
5208f0f
Compare
scommisso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into callStackOverflow exceptions with small-ish JSON (between 300kb and 2mb) files when running in Node 0.10. This seems to have fixed the problem. (Also documented in #11)
Also updated the package.json so that
npm testruns the unit tests.A pre-publish step runs
browserifyon the source to create the browser-friendly version.Also added an optional
optionsobject. Currently the only option is:limit: overridesDEFAULT_COUNTER_LIMIT(defaults to200)This can be expanded to support other options supported by
JSON.stringify()(spacing, etc.)