-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #181
base: master
Are you sure you want to change the base?
Update dependencies #181
Conversation
@@ -10,6 +10,7 @@ impl Dummy<Faker> for RandomColor { | |||
luminosity: Some(Luminosity::Random), | |||
seed: Some((u64::MIN..u64::MAX).fake_with_rng::<u64, _>(rng)), | |||
alpha: Some((0..10).fake_with_rng::<i8, _>(rng) as f32 / 10.), | |||
..Default::default() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed for random_color v0.8
[package.metadata.cargo-all-features] | ||
denylist = ["geo-types", "serde_json"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also be solved by adding these to [features]
so their other co-dependencies can be specified
IMO there is too much happening here. I am going to break it into smaller PRs. |
default-features = false
more to reduce deps & compile timeHere is the reason for MSRV being bumped