feat: add url feature #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cksac
reviewed
Aug 5, 2024
fake/src/impls/url/mod.rs
Outdated
|
|
||
| impl Dummy<Faker> for Url { | ||
| fn dummy_with_rng<R: Rng + ?Sized>(_: &Faker, rng: &mut R) -> Self { | ||
| let path: String = Faker.fake_with_rng(rng); |
There was a problem hiding this comment.
are arbitrary string can be a valid path?
There was a problem hiding this comment.
I think it is. If path is [a-zA-Z], it must be valid.
However, I think it's better to define paths as const.
FIXED: c736536
fake/src/impls/url/mod.rs
Outdated
| impl Dummy<Faker> for Url { | ||
| fn dummy_with_rng<R: Rng + ?Sized>(_: &Faker, rng: &mut R) -> Self { | ||
| let path: String = Faker.fake_with_rng(rng); | ||
| Url::parse(&format!("{FQDN}/{path}")).unwrap() |
There was a problem hiding this comment.
the unwrap may panic due to path is not valid, I think we should make it alway valid path?
#[cfg(test)]
mod test {
use super::*;
#[test]
fn valid_urls_generated() {
for _ in 0..10 {
let url = Faker.fake::<Url>();
println!("{}", url);
}
}
}I tried this test. it worked. |
|
@cksac |
|
LGTM. will fix the Clippy warning later |
|
Thank you @cksac ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue: #189
I think it's best to use https://example.com/ as a fixed URL.