Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for re-exporting crate #198

Merged
merged 1 commit into from
Oct 29, 2024
Merged

adds support for re-exporting crate #198

merged 1 commit into from
Oct 29, 2024

Conversation

colstrom
Copy link
Contributor

Hiya, thanks for making fake! It's helped me out when testing things, and has even caught a few bugs!

This is a small change to enable using fake when re-exporting it from a crate (as one might do with macros, for instance).

Currently, the anchored ::fake paths effectively require the depending crate to directly depend on fake. This removes those, and (as far as I'm aware) should not break anything except the probably-rare case where there is another module named fake in the current scope, in which case the fix would be to anchor the reference there, rather than requiring it universally to avoid that one weird scenario.

Tests still pass, and I've haven't touched the versioning, since I'm not quite sure what the appropriate bump would be for this. If there's any changes you'd like me to make, just let me know.

Thanks again for making something cool. You rock! ❤️

@cksac cksac merged commit da632de into cksac:master Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants