Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"raw" labelset from the current SR annotation is overpopulated #102

Closed
keighrim opened this issue Jun 12, 2024 · 1 comment · Fixed by #107 or #106
Closed

"raw" labelset from the current SR annotation is overpopulated #102

keighrim opened this issue Jun 12, 2024 · 1 comment · Fixed by #107 or #106
Labels
🐛B Something isn't working

Comments

@keighrim
Copy link
Member

keighrim commented Jun 12, 2024

Bug Description

When we run the app, it returns classification results (on each timepoint) on 22 labels

(for example)

              "B": 1.2004544025501218e-08,
              "S": 0.9911466240882874,
              "S:H": 4.395981408750194e-12,
              "S:C": 7.746329619418013e-12,
              "S:D": 3.075464145504969e-12,
              "S:B": 1.7393599581472241e-12,
              "S:G": 8.484618389814624e-12,
              "W": 0.0018126036738976836,
              "L": 8.085626177489758e-06,
              "O": 0.004137764219194651,
              "M": 2.2342723241308704e-05,
              "I": 0.0005785876419395208,
              "N": 7.963440293679014e-05,
              "E": 5.8202545005769935e-06,
              "P": 1.7434373376090662e-06,
              "Y": 3.64386693263441e-07,
              "K": 4.580545919452561e-06,
              "G": 0.0019418805604800582,
              "T": 4.255012754583731e-05,
              "F": 8.692211395100458e-07,
              "C": 3.8110854802653193e-05,
              "R": 0.0001566969440318644,
              "NEG": 2.1870659111300483e-05

But the subtype-suffixed labels were never actually used when reading the annotations for training

pre_binned_label = pretraining_bin(labels['frames'][i]['label'], configs)

(subtype labels are stored as labels['frames'][i]['lsubtype_abel'] in the preprocessed annotation metadata file)

But used in softmax space.

def int_encode(label):
if not isinstance(label, str):
return label
if label in FRAME_TYPES:
return FRAME_TYPES.index(label)

and

FRAME_TYPES = ["B", "S", "S:H", "S:C", "S:D", "S:B", "S:G", "W", "L", "O",
"M", "I", "N", "E", "P", "Y", "K", "G", "T", "F", "C", "R"]

We need to fix the code so that subtypes are not used in softmax layer, or subtypes are used in training example. (In the latter case, we should instead take out S label)

Reproduction steps

Run SWT on a video, confirm the labelset in the TimePoint annotation objects are 22-way classification.

Expected behavior

No response

Log output

No response

Screenshots

No response

Additional context

(full label definition is in #1)

@keighrim
Copy link
Member Author

shouldn't have been closed, since the PR didn't include new model with a smaller softmax dimension.

@keighrim keighrim reopened this Jun 26, 2024
keighrim added a commit that referenced this issue Jun 27, 2024
- new models are trained with the same hyperparams as the old models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛B Something isn't working
Projects
Archived in project
1 participant