Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to clams-python 1.2.5 #106

Merged
merged 9 commits into from
Jun 27, 2024
Merged

updating to clams-python 1.2.5 #106

merged 9 commits into from
Jun 27, 2024

Conversation

keighrim
Copy link
Member

@keighrim keighrim commented Jun 26, 2024

  • updating to clams-python 1.2.5,
  • big refactor to declutter inter-dependency between app.py, Classifier, and Stitcher classes
  • removed (unmaintained) CLI in classifier.py, since app.py and cli.py can complete replace its functionality
  • replaced old 22-way models with newly trained (under the same hyperparam) 18-way models (fixes "raw" labelset from the current SR annotation is overpopulated #102 )

… `credit` label back to `credits`

- clamsproject/mmif#188 (comment)
- clamsproject/app-role-filler-binder#2 (comment)
- importing `app.py` from `metadata.py` requires the entire dependencies to be in place. I change the dependency direction so that `metadata.py` can run just with `clams-python` dependency
- app,py no longer handles model file suffixing
- removed unused stand-alone classifier CLI
    - all point-wise classification now in MMIF
    - cli.py can fully replace CLI in classifier.py
- renamed trainer config file to make it clear that's just an example
- new models are trained with the same hyperparams as the old models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"raw" labelset from the current SR annotation is overpopulated
1 participant