Enable image-based data preprocessing in data_loader.py #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keighrim
requested changes
Jul 24, 2024
modeling/data_loader.py
Outdated
| frame_metadata = {'frames': []} | ||
| frame_vecs = defaultdict(list) | ||
| print(f'processing video: {vid_path}') | ||
| for i, frame in tqdm(enumerate(self.get_stills(vid_path, csv_path))): | ||
| if is_dir == True: |
There was a problem hiding this comment.
I guess conditional in lines 178-182 can be directly moved to here?
modeling/data_loader.py
Outdated
| if is_directory: | ||
| # Process as directory of images | ||
| for frame in frame_list: | ||
| image_path = os.path.join(path, frame.filename) |
There was a problem hiding this comment.
I'm not sure what is the problem here, but running the preprocessor only processes the first video in the csv. For example:
py -m modeling.data_loader -i challenge_2-1_pbd/images -c challenge_2-1_pbd/img_labels.csv
results in only one set of json + npy files for cpb-aacip-110-16c2ftdq (which is the first video in the csv). So I guess there's a bug somewhere around here.
…nal frame traversal used during annotating This reverts commit 5a15e2d.
… single loop for efficiency
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #112