-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation with clams-python 1.2.4 #3
Conversation
Delete features1.pkl Delete tfidf_vectors1.pkl
Delete CLAMS/tfidf-kw-detection/app-tfidf-keywordextractor_1.2.4/tfidf.py app-tfidf-keywordextractor with clams 1.2.4 new version of app with clams-python 1.2.4 new version of app with clams-python 1.2.4 Delete input.mmif Delete test_run_nlp_tool.py Delete CLAMS/tfidf-kw-detection/app-tfidf-keywordextractor_1.2.4 directory Rename CLAMS/tfidf-kw-detection/app-tfidf-keyword-detector_1.2.2/Containerfile to Containerfile app with clams-python 1.2.4, moving the files out of the directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please find my feedback in the in-line comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some spots that need some revisit.
text document. | ||
* The ones whose last view containing TextDocument(s) is the view to extract keywords from. | ||
|
||
> **~~note:~~** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just so you know... https://github.com/orgs/community/discussions/16925
fixes #1