Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation with clams-python 1.2.4 #3

Merged
merged 11 commits into from
Jul 19, 2024
Merged

Conversation

selenasong
Copy link
Contributor

@selenasong selenasong commented Jun 25, 2024

fixes #1

selenasong and others added 2 commits June 25, 2024 16:06
Delete features1.pkl

Delete tfidf_vectors1.pkl
Delete CLAMS/tfidf-kw-detection/app-tfidf-keywordextractor_1.2.4/tfidf.py

app-tfidf-keywordextractor with clams 1.2.4

new version of app with clams-python 1.2.4

new version of app with clams-python 1.2.4

Delete input.mmif

Delete test_run_nlp_tool.py

Delete CLAMS/tfidf-kw-detection/app-tfidf-keywordextractor_1.2.4 directory

Rename CLAMS/tfidf-kw-detection/app-tfidf-keyword-detector_1.2.2/Containerfile to Containerfile

app with clams-python 1.2.4, moving the files out of the directory
Copy link
Member

@keighrim keighrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please find my feedback in the in-line comments.

app.py Outdated Show resolved Hide resolved
metadata.py Show resolved Hide resolved
metadata.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
Copy link
Member

@keighrim keighrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

LICENSE Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Member

@keighrim keighrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some spots that need some revisit.

app.py Outdated Show resolved Hide resolved
tfidf.py Outdated Show resolved Hide resolved
metadata.py Outdated Show resolved Hide resolved
metadata.py Outdated Show resolved Hide resolved
metadata.py Outdated Show resolved Hide resolved
tfidf.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
metadata.py Outdated Show resolved Hide resolved
text document.
* The ones whose last view containing TextDocument(s) is the view to extract keywords from.

> **~~note:~~**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@selenasong selenasong merged commit 7a4faa6 into main Jul 19, 2024
@keighrim keighrim mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input/output specification
2 participants