Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releasing 1.1.0 #192

Merged
merged 31 commits into from
Jan 31, 2024
Merged

releasing 1.1.0 #192

merged 31 commits into from
Jan 31, 2024

Conversation

keighrim
Copy link
Member

Overview

This is a minor-level release that fixes various bugs and adds safeguards for possible inconsistency in output MMIFs.

Additions

$ clams rewind --help
usage: clams rewind [-h] [-o PATH] [-p] [-n NUMBER] [-m {app,view}] mmif_file

provides CLI to rewind a MMIF from a CLAMS pipeline.

MMIF rewinder rewinds a MMIF by deleting the last N views.
N can be specified as a number of views, or a number of producer apps.

positional arguments:
  mmif_file             Path to the input MMIF file, or '-' to read from stdin.

optional arguments:
  -h, --help            show this help message and exit
  -o PATH, --output PATH
                        Path to the rewound MMIF output file. When not given, the rewound MMIF is printed to stdout.
  -p, --pretty          Pretty-print rewound MMIF. True by default
  -n NUMBER, --number NUMBER
                        Number of views to rewind (default: interactive mode)
  -m {app,view}, --mode {app,view}
                        Number of views to rewind (default: interactive mode)

Changes

keighrim and others added 30 commits July 18, 2023 21:41
added validation step in `annotate()` before return the MMIF JSON str
* plus, small fixes in the app dev template
* made sanitation as default behavior of MMIF serialization
* and `sign_view` detects and uses "raw" param dict to sign
sign_view now uses "raw" input parameters, if available.
added logging-to-stdout for production mode restifier
no pip cache in container images to reduce image sizes
fixed `git describe` error when whitespace in git path
adding back app user manual to this repo
- changed rewinder file name taking off mmif_.
- changed _delete_last function name to be single underscored.
- added CLI argument for number of views to rewind.
- changed read_mmif from json.load() -> file.read()
* optimized MMIF file I/O
* added rewinding by number of apps (opposed to number of views, not exposed in CLI)
Implementation of mmif rewinder
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (b45e267) 76.77% compared to head (45ae3b8) 73.69%.
Report is 15 commits behind head on main.

Files Patch % Lines
clams/mmif_utils/rewind.py 48.10% 41 Missing ⚠️
clams/__init__.py 60.00% 2 Missing ⚠️
clams/app/__init__.py 90.90% 2 Missing ⚠️
clams/appmetadata/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   76.77%   73.69%   -3.08%     
==========================================
  Files           7        9       +2     
  Lines         633      730      +97     
==========================================
+ Hits          486      538      +52     
- Misses        147      192      +45     
Flag Coverage Δ
unittests 73.69% <59.64%> (-3.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim keighrim merged commit 7bf0907 into main Jan 31, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants