-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releasing 1.1.0 #192
Merged
releasing 1.1.0 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added validation step in `annotate()` before return the MMIF JSON str
* plus, small fixes in the app dev template * made sanitation as default behavior of MMIF serialization
* and `sign_view` detects and uses "raw" param dict to sign
sign_view now uses "raw" input parameters, if available.
added logging-to-stdout for production mode restifier
no pip cache in container images to reduce image sizes
fixed `git describe` error when whitespace in git path
adding back app user manual to this repo
- changed rewinder file name taking off mmif_. - changed _delete_last function name to be single underscored. - added CLI argument for number of views to rewind. - changed read_mmif from json.load() -> file.read()
* optimized MMIF file I/O * added rewinding by number of apps (opposed to number of views, not exposed in CLI)
Implementation of mmif rewinder
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 76.77% 73.69% -3.08%
==========================================
Files 7 9 +2
Lines 633 730 +97
==========================================
+ Hits 486 538 +52
- Misses 147 192 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a minor-level release that fixes various bugs and adds safeguards for possible inconsistency in output MMIFs.
Additions
sign_view
now use user input parameters "as-is" whenever they are available (sign_view now uses "raw" input parameters, if available. #181)clams rewind
is now available to rewind MMIF files (MMIF rewinder #190)Changes