Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default values for mutlivalued=True params now must be lists #203

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

keighrim
Copy link
Member

additional fix for #197

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.49%. Comparing base (ef4b59c) to head (906c486).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #203      +/-   ##
===========================================
+ Coverage    74.39%   74.49%   +0.10%     
===========================================
  Files            9        9              
  Lines          738      745       +7     
===========================================
+ Hits           549      555       +6     
- Misses         189      190       +1     
Flag Coverage Δ
unittests 74.49% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim keighrim force-pushed the 197-map-typed-param branch from fb70c05 to 906c486 Compare March 28, 2024 22:29
@keighrim keighrim merged commit 0edf198 into develop Mar 28, 2024
3 checks passed
@keighrim keighrim deleted the 197-map-typed-param branch March 29, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant