-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releasing 1.1.4 #205
Merged
releasing 1.1.4 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for `map` type runtime parameter
added methods that allows additional type-level descriptions
default values for `mutlivalued=True` params now must be lists
* updated to `mmif-python==1.0.11` * parameter type casting now happens in `ClamsApp` class, instead of on the restifier wrapper layer (updated all test cases for this) * all "raw" parameters passed to the app are now assumed to be a list of string values, directly from `flask.request.args.to_dict(flat=False)`
signing a view now auto-record `appConfiguration`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 74.30% 73.87% -0.44%
==========================================
Files 9 9
Lines 724 758 +34
==========================================
+ Hits 538 560 +22
- Misses 186 198 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This release includes many changes regarding runtime parameters.
Additions
views[].metadata.appConfiguration
field added in MMIF 1.0.4 (sign_view
andget_configuration
#166)map
type parameters to provide (limited) support for complex data types. At the moment,map
type parameters are expected to be parsed into string-to-string dictionary. See the metadata jsonscheme for the full documentation (support for "map" typed runtime parameter #197)Changes
multivalued=True
parameters has been interpreted as lists but default values weren't. Now it's fixed. (related to support for "map" typed runtime parameter #197 as well, sincetype=map
impliesmultivalued=True
)