-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding cli.py
for command line app use
#217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some in-line comments. Also, for commit logs don't seem to be very informative anyway. If the commits are small, incremental changes, how about squash them during we're working in the PR, before merge the history into the main?
59a506a
to
c5c0387
Compare
c5c0387
to
d8f0855
Compare
- since `store_true/false` makes the behavior hard to predict (see https://github.com/clamsproject/app-swt-detection/blob/4acc07de8557e8962a9729e6eb39569462e1d7da/cli.py#L93-L94)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #217 +/- ##
===========================================
- Coverage 73.94% 72.65% -1.29%
===========================================
Files 9 9
Lines 756 779 +23
===========================================
+ Hits 559 566 +7
- Misses 197 213 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
requesting review from @marcverhagen . Particularly regarding the documentation at https://github.com/clamsproject/clams-python/blob/a8ae2afc1e589976cf837f108ae85f60999092fe/documentation/clamsapp.md#using-clams-app-as-a-cli-program |
This PR addresses #198 , by adding a "cli.py" template to the clams SDK. This script iterates over the "parameters" in a new app's metadata and parses them into argparse arguments. From here, it collects those arguments and stdin, runs
app._annotate()
, and produces the result to stdoutReview
Generally, I think the areas that I'm least sure about: