Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in property type checker #256

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

keighrim
Copy link
Member

@keighrim keighrim commented Feb 6, 2024

bugfix of #255, and fixes #252

@keighrim
Copy link
Member Author

keighrim commented Feb 6, 2024

not sure I want to merge this, though, while clamsproject/mmif#215 is open.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f4d9ab5) 91.82% compared to head (787ca84) 91.68%.
Report is 2 commits behind head on develop.

Files Patch % Lines
mmif/serialize/annotation.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #256      +/-   ##
===========================================
- Coverage    91.82%   91.68%   -0.15%     
===========================================
  Files            8        8              
  Lines         1040     1046       +6     
===========================================
+ Hits           955      959       +4     
- Misses          85       87       +2     
Flag Coverage Δ
unittests 91.68% <80.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim keighrim merged commit 606c113 into develop Feb 7, 2024
1 of 3 checks passed
@keighrim keighrim deleted the 252-dict-as-annotation-prop branch February 7, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Simple dictionaries are not allowed in annotation properties
1 participant