Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub-page/sub-URL generation #28

Merged
merged 13 commits into from
Sep 13, 2023
Merged

sub-page/sub-URL generation #28

merged 13 commits into from
Sep 13, 2023

Conversation

keighrim
Copy link
Member

fixes #26 .

@keighrim keighrim changed the base branch from develop to main August 27, 2023 15:47
@keighrim keighrim marked this pull request as draft August 27, 2023 18:23
@keighrim keighrim marked this pull request as ready for review August 27, 2023 23:39
@haydenmccormick
Copy link
Collaborator

haydenmccormick commented Sep 9, 2023

When using the full at_type as the label for the document tab, you often get awkward stacking like this:

image

From a UI perspective, I think it might be better to have the short names as the tab labels, then maybe the full at_type printed next to the document location. @keighrim would it be alright if I made that change?

@keighrim
Copy link
Member Author

It was totally my oversight, and just fixed it. Feel free to add further commits or merge.

@haydenmccormick haydenmccormick merged commit 0b1ed87 into main Sep 13, 2023
@haydenmccormick haydenmccormick deleted the url_access branch September 30, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

persistent visualization rendering as a sub-page
2 participants