Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved lastfm support #676

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Improved lastfm support #676

merged 1 commit into from
Jul 13, 2024

Conversation

al1-ce
Copy link
Contributor

@al1-ce al1-ce commented May 16, 2024

Added:

  • Tracks will now be displayed as "currently playing" on lastfm after 2.5 second

Changed:

  • Tracks will be considered played after either 1/4 length of track or 25 seconds (picks lesser one) (consider tracks that are >1hour long, it'd be 25 minutes vs 25 seconds... yea)

Fixes #675 and develops on #288

Also on my experience musikcube refused to build without #662

@clangen
Copy link
Owner

clangen commented Jul 13, 2024

This is awesome, thank you!

(Apologies for the delay, real life has been busy the past few months).

@clangen clangen merged commit 4815178 into clangen:master Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lastfm improvement?
2 participants