Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Cleanup travis configuration for old artifcats #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup travis configuration for old artifcats #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,12 @@ rust:
- beta
- stable
- nightly
matrix:
include:
- rust: nightly-2018-07-22
env: CLIPPY=YESPLEASE
script:
- rustup component add clippy-preview
- cargo clippy -- -D warnings
- rust: 1.27.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advantage of pinning the version for rustfmt is your CI won't break when a new version of Rust is out that tweaks the format.

env: RUSTFMT=YESPLEASE
script:
- rustup component add rustfmt-preview
- cargo fmt --all -- --write-mode=diff

script:
- cargo fmt --all -- --write-mode=diff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides not pinning rustfmt, a disadvantage of running it in the regular job is that it will be duplicated per environment which I doubt you need.

- cargo build --all --all-features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you could just run cargo check

- cargo test --all --all-features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to drop clippy?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but only temporarily until I figured out what to do with the codebase (maybe a big"ish" refactoring).


notifications:
email:
on_success: never