fix(parser): Allow help and version command #4988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4392
Context
The help and version command are considered errors, though they are not "true" ones (I'm curious to know why they're considered errors to begin with 🤔 )
clap/clap_builder/src/error/kind.rs
Lines 259 to 277 in 1f71fd9
clap/clap_builder/src/error/kind.rs
Lines 303 to 317 in 1f71fd9
As a result, when
ignore_errors
is true, the output from the help and version commands are ignored.Changes in this PR
This PR adds an explicit check so that only "true" errors are ignored